Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Linkedin Ads: support of oAuth2 #7839

Merged
merged 51 commits into from
Nov 18, 2021
Merged

Conversation

antixar
Copy link
Contributor

@antixar antixar commented Nov 11, 2021

How

Add an implementation of oAuth2 logic to the connector and the Java server part

Manual result of tests:

  1. Redirect to the Linkedin Ads auth windows:
    image
  2. Auth result:
    image

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

gl-pix and others added 30 commits September 28, 2021 19:15
…zendesk_support/streams.py

Co-authored-by: George Claireaux <george@claireaux.co.uk>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: LiRen Tu <tuliren@gmail.com>
@antixar antixar temporarily deployed to more-secrets November 16, 2021 17:32 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 16, 2021 17:34 Inactive
| `string` | `string` | |
| Integration Type | Airbyte Type | Notes |
| :--------------- | :----------- | :------------------------- |
| `number` | `number` | float number |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for formatting.

@antixar
Copy link
Contributor Author

antixar commented Nov 18, 2021

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1476597598
❌ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1476597598
🐛 https://gradle.com/s/ciqivcueebmgo

@antixar antixar temporarily deployed to more-secrets November 18, 2021 13:26 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 13:28 Inactive
@antixar
Copy link
Contributor Author

antixar commented Nov 18, 2021

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1476670121
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1476670121
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                               Stmts   Miss  Cover
	 ------------------------------------------------------
	 source_linkedin_ads/__init__.py        2      0   100%
	 source_linkedin_ads/analytics.py      45      1    98%
	 source_linkedin_ads/source.py        163     73    55%
	 source_linkedin_ads/utils.py          83      5    94%
	 ------------------------------------------------------
	 TOTAL                                293     79    73%

@antixar antixar temporarily deployed to more-secrets November 18, 2021 13:46 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 13:47 Inactive
@antixar
Copy link
Contributor Author

antixar commented Nov 18, 2021

/publish connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1476719560
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1476719560

@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 14:01 Inactive
@antixar antixar temporarily deployed to more-secrets November 18, 2021 14:30 Inactive
@antixar antixar temporarily deployed to more-secrets November 18, 2021 14:35 Inactive
@antixar antixar merged commit 82c4c82 into master Nov 18, 2021
@antixar antixar deleted the antixar/7709-linkedin-oauth2 branch November 18, 2021 14:36
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* fix 404 responses for the ticket_comments stream

* add unit test

* add unit test

* add oauth2 access token

* Update airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py

Co-authored-by: George Claireaux <george@claireaux.co.uk>

* switching among auth methods

* update spec file

* update CI secrets logic

* remove debug data

* add a debug message

* fix json convertation

* support one secret by several connectors

* Update tools/bin/ci_credentials.sh

Co-authored-by: LiRen Tu <tuliren@gmail.com>

* update function names

* update docs

* reset failed changes

* update json set value

* update spec file

* add oauth2 logic

* update doc and version

* add tests

* correction of spec

* update tests

* update spec file

Co-authored-by: Maksym Pavlenok <maksym.pavlenok@globallogic.com>
Co-authored-by: George Claireaux <george@claireaux.co.uk>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: LiRen Tu <tuliren@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Linkedin Ads: support oauth
7 participants