Stop using gentle close with heartbeat #8036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
lmossman
commented
Nov 17, 2021
| @@ -134,28 +134,15 @@ static void gentleCloseWithHeartbeat(final Process process, | |||
| } | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| static void forceShutdown(final Process process, final Duration lastChanceDuration) { | |||
There was a problem hiding this comment.
This method was basically a copy of closeProcess(), but without the logic to actually forcibly shutdown the process (despite the name). So I opted to just remove it and use closeProcess in its place instead.
jrhizor
approved these changes
Nov 17, 2021
cgardens
reviewed
Nov 18, 2021
| @@ -36,6 +36,11 @@ | |||
| "title": "Max Records", | |||
| "description": "Number of records to emit. If not set, defaults to infinity.", | |||
| "type": "integer" | |||
| }, | |||
| "message_interval": { | |||
There was a problem hiding this comment.
fwiw this field could probably be optional.
@lmossman lmk when you get around tot his bit! |
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* use gentle close instead of gentle close with heartbeat when closing source * also lower destination process gentle close duration * add test connectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/airbytehq/oncall/issues/15
Currently, when a destination fails it causes
close()to be called on the source and destination. However, the current implementation of this waits until the source process finishes its heartbeats, and then has an extremely long wait time (10 hours) before actually destroying the process, which makes the sync appear to hang during this time.This PR solves the issue by removing the heartbeat check (this wasn't really useful anyway, as heartbeats were only listened to once the process was trying to be closed due to a finished job or error), and lowering the wait time to close the process from 10 hours to 1 minute.
I have tested this out locally using the e2e connectors that this PR adds, and it causes the source process to correctly be promptly closed once after the destination process fails.
Planning to add an acceptance test for this case in a separate PR, as the test will likely take multiple minutes to run and we therefore might not want to add it until we have proper asynchronous testing in place.