-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Linnworks: refactor stream StockLocations #8169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @monai for this cool refacto, I made minor suggestions + committed the docker image version bump. Let me know if you plan to make the suggested modification, I'll publish the docker image update from my side branch.
airbyte-integrations/connectors/source-linnworks/unit_tests/test_streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linnworks/source_linnworks/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linnworks/source_linnworks/streams.py
Show resolved
Hide resolved
Thank you for review. I'm going to make changes on monday. |
Thanks for the changes and this clean contrib, ready for merge! 🎉 |
What
This PR refactors private stream
Location
, which was embedded into streamStockLocation
, to public streamStockLocationDetails
utilizingHttpSubStream
. From now on,StockLocations
can be synced independently, whileStockLocationDetails
performs single sync ofStockLocations
, resulting in N+1 requests.Recommended reading order
streams.py
source.py
🚨 User Impact 🚨
🚨🚨 This PR changes the stream
StockLocations
schema.Pre-merge Checklist
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here