Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Google Analytics: Fix issue with custom error and simplify configuration #8175

Merged
merged 11 commits into from
Dec 3, 2021
Merged

🐛 Source Google Analytics: Fix issue with custom error and simplify configuration #8175

merged 11 commits into from
Dec 3, 2021

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Nov 22, 2021 •
edited
Loading

What

#8049 - Fix issue with custom error
#7850 - Simplify configuration

How

When the connector gets a custom report which has unknown metric(s) or dimension(s) and API returns an error with 400 code, the connector ignores an error with 400 code to finish successfully sync and inform the user about an error in logs with an error message.

Changed order and name for some values. Deleted window_in_days and added default value as 90 days.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

This was linked to issues Nov 22, 2021
Simplify configuration for Google Analytics #7850
Closed
Google Analytics issue with custom reports if data does not exist #8049
Closed
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 22, 2021
antixar
antixar reviewed Nov 23, 2021
View reviewed changes
Copy link
Contributor

@antixar antixar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an unit test for this case?

airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
@lazebnyi lazebnyi temporarily deployed to more-secrets November 23, 2021 11:32 Inactive
antixar
antixar approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please merge and publish your changes. Don't forget to update the PR number in the changelog

@lazebnyi lazebnyi marked this pull request as ready for review November 24, 2021 11:14
@lazebnyi lazebnyi temporarily deployed to more-secrets November 24, 2021 11:15 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets November 24, 2021 11:22 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets November 24, 2021 12:10 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 3, 2021 11:18 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 3, 2021 11:23 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 3, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1535002864
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1535002864

@jrhizor jrhizor temporarily deployed to more-secrets December 3, 2021 11:29 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 3, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1535039593
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1535039593

@lazebnyi lazebnyi temporarily deployed to more-secrets December 3, 2021 11:39 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 3, 2021 11:39 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 3, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1535071753
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1535071753

@lazebnyi lazebnyi temporarily deployed to more-secrets December 3, 2021 11:50 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 3, 2021 11:50 Inactive
@lazebnyi lazebnyi merged commit 9270f32 into master Dec 3, 2021
@lazebnyi lazebnyi deleted the lazebnyi/8049-fix-issue-with-custom-reports branch December 3, 2021 11:59
@lazebnyi lazebnyi temporarily deployed to more-secrets December 3, 2021 12:00 Inactive
@jrhizor jrhizor mentioned this pull request Dec 3, 2021
Merged
This was referenced Dec 7, 2021
Closed
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@lazebnyi @schlattk
🐛 Source Google Analytics: Fix issue with custom error and simplify c…
ecb29a2 
…onfiguration (airbytehq#8175)

* Fix validation of unknown metric(s) or dimension(s) error and chenge spec values order

* Add unit test and docs to method

* Updated PR number

* Updated version

* Updated version

* Bumped docker version

* Fix code formation

* Fixed unit tests

* Bumped version in seeds and spec yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antixar antixar antixar approved these changes

Assignees

@lazebnyi lazebnyi

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
No open projects
GL Roadmap
Archived in project
Milestone
No milestone
3 participants
@lazebnyi @antixar @jrhizor