Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Intercom: stop using time.sleep as a hacky rate limit #8685

Merged
merged 5 commits into from
Dec 14, 2021

Conversation

bkrausz
Copy link
Contributor

@bkrausz bkrausz commented Dec 10, 2021

What

Intercom source syncs are currently unnecessarily slow. This is because we don't rely on the natural rate limit mechanism, and instead proactively sleep after each request. Many requests, when run in serial, take longer than the rate limit would care about, so the rate limit wouldn't even be triggered, and when it is the CDK's backoff will handle it without issue.

How

Removes the time.sleep

Recommended reading order

N/A

🚨 User Impact 🚨

Faster syncs

Pre-merge Checklist

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 10, 2021
@bkrausz bkrausz changed the title Stop using time.sleep as a hacky rate limit 🐛 Source Intercom: stop using time.sleep as a hacky rate limit Dec 10, 2021
@marcosmarxm
Copy link
Member

Related PR: #5123

@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/scheduler area/server area/worker Related to worker CDK Connector Development Kit kubernetes normalization labels Dec 14, 2021
@marcosmarxm marcosmarxm temporarily deployed to more-secrets December 14, 2021 16:04 Inactive
@github-actions github-actions bot removed area/platform issues related to the platform CDK Connector Development Kit area/scheduler area/frontend kubernetes normalization area/worker Related to worker labels Dec 14, 2021
@marcosmarxm marcosmarxm temporarily deployed to more-secrets December 14, 2021 16:06 Inactive
@marcosmarxm marcosmarxm merged commit 3d9af64 into airbytehq:master Dec 14, 2021
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…tehq#8685)

* Stop using time.sleep as a hacky rate limit

* bump connector version

* run seed config

Co-authored-by: Marcos Marx <marcosmarxm@gmail.com>
@bkrausz bkrausz deleted the intercom-no-sleep branch March 12, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants