-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Intercom: stop using time.sleep as a hacky rate limit #8685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkrausz
changed the title
Stop using time.sleep as a hacky rate limit
🐛 Source Intercom: stop using time.sleep as a hacky rate limit
Dec 10, 2021
Related PR: #5123 |
lazebnyi
approved these changes
Dec 13, 2021
github-actions
bot
added
area/documentation
Improvements or additions to documentation
area/frontend
area/platform
issues related to the platform
area/scheduler
area/server
area/worker
Related to worker
CDK
Connector Development Kit
kubernetes
normalization
labels
Dec 14, 2021
github-actions
bot
removed
area/platform
issues related to the platform
CDK
Connector Development Kit
area/scheduler
area/frontend
kubernetes
normalization
area/worker
Related to worker
labels
Dec 14, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…tehq#8685) * Stop using time.sleep as a hacky rate limit * bump connector version * run seed config Co-authored-by: Marcos Marx <marcosmarxm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Intercom source syncs are currently unnecessarily slow. This is because we don't rely on the natural rate limit mechanism, and instead proactively sleep after each request. Many requests, when run in serial, take longer than the rate limit would care about, so the rate limit wouldn't even be triggered, and when it is the CDK's backoff will handle it without issue.
How
Removes the
time.sleep
Recommended reading order
N/A
🚨 User Impact 🚨
Faster syncs
Pre-merge Checklist
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog example