Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in destination-connectors specifications: azure-blob-storage, bigquery, bigquery-denormalized, cassandra, csv, dynamodb, elasticsearch, firestore #8786

Closed

Conversation

karinakuz
Copy link
Contributor

@karinakuz karinakuz commented Dec 14, 2021

What

Add title and description properties to each field in destination-connectors specifications:
destination-azure-blob-storage
destination-bigquery
destination-bigquery-denormalized
destination-cassandra
destination-csv
destination-dynamodb
destination-elasticsearch
destination-firestore

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here


This change is Reviewable

@karinakuz karinakuz added area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Dec 14, 2021
@karinakuz karinakuz self-assigned this Dec 14, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Karina seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 14, 2021
@karinakuz karinakuz temporarily deployed to more-secrets December 14, 2021 14:34 Inactive
@karinakuz karinakuz temporarily deployed to more-secrets December 15, 2021 12:25 Inactive
@sherifnada
Copy link
Contributor

won't be able to review, pls ask for review from someone else

@igrankova igrankova requested review from misteryeo and removed request for sherifnada December 17, 2021 10:06
@igrankova
Copy link
Contributor

e2e-test - no changes needed

@igrankova igrankova changed the title Update fields in destination-connectors specifications: azure-blob-storage, bigquery, bigquery-denormalized, cassandra, csv, dynamodb, e2e-test, elasticsearch, firestore Update fields in destination-connectors specifications: azure-blob-storage, bigquery, bigquery-denormalized, cassandra, csv, dynamodb, elasticsearch, firestore Mar 30, 2022
@igrankova igrankova added the unblockers Defines Unblockers Team label May 12, 2022
@misteryeo misteryeo closed this Jun 14, 2022
@swyxio swyxio deleted the karinakuz/issue-8744-update-title-description branch October 12, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment