Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source DB2: fixed Db2SourceCertificateAcceptanceTest #9187

Merged
merged 2 commits into from
Dec 31, 2021

Conversation

yurii-bidiuk
Copy link
Contributor

What

Fixes #9146

How

Use TLSV12 for tests

Recommended reading order

  1. Db2StrictEncryptSourceCertificateAcceptanceTest.java
  2. Db2SourceCertificateAcceptanceTest.java

🚨 User Impact 🚨

There is no user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 29, 2021

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1634352048
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1634352048
No Python unittests run

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 29, 2021
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 29, 2021

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1634352892
❌ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1634352892
🐛 https://gradle.com/s/uxbxxlz64b5hm

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1634352892

@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 14:37 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 14:37 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 15:17 Inactive
@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets December 29, 2021 15:27 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 29, 2021

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1634511082
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1634511082
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 15:29 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 30, 2021
@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets December 30, 2021 12:24 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 30, 2021

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1637811466
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1637811466
No Python unittests run

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 30, 2021

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1637811711
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1637811711
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 14:40 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 14:40 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 31, 2021

/publish connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1641029211
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1641029211

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 31, 2021

/publish connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1641029485
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1641029485

@jrhizor jrhizor temporarily deployed to more-secrets December 31, 2021 14:53 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 31, 2021 14:53 Inactive
@yurii-bidiuk yurii-bidiuk marked this pull request as ready for review December 31, 2021 15:45
@yurii-bidiuk yurii-bidiuk merged commit 99a2ae6 into master Dec 31, 2021
@yurii-bidiuk yurii-bidiuk deleted the bidiuk/9146-fix-db2-tests branch December 31, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source DB2: failed Db2SourceCertificateAcceptanceTest
4 participants