Source Amazon Seller Partner: add all remaining brand analytics report streams #9312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/documentation
|
Thanks @monai for the contribution, we're going to review as soon as possible :) |
harshithmullapudi
suggested changes
Jan 11, 2022
Comment on lines
-391
to
-395
| class BrandAnalyticsSearchTermsReports(ReportsAmazonSPStream): | ||
| """ | ||
| Field definitions: https://sellercentral.amazon.co.uk/help/hub/reference/G5NXWNY8HUD3VDCW | ||
| """ | ||
|
|
There was a problem hiding this comment.
any reason why we removed this?
There was a problem hiding this comment.
I refactored it to BrandAnalyticsStream and BrandAnalyticsSearchTermsReports(BrandAnalyticsStream).
harshithmullapudi
approved these changes
Jan 11, 2022
Comment on lines
-291
to
-292
| @staticmethod | ||
| def parse_document(document): |
There was a problem hiding this comment.
Hey, isn't this method just as a util?
There was a problem hiding this comment.
I made it an instance method because in BrandAnalyticsStream it accesses instance variable. See
This was referenced Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add all remaining brand analytics report streams.
Recommended reading order
source.pystreams.pyPre-merge Checklist
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here