Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 SAT: Fix test_oneof_usage fail #9860 #9861

Merged
merged 11 commits into from
Jan 28, 2022
Merged

🐛 SAT: Fix test_oneof_usage fail #9860 #9861

merged 11 commits into from
Jan 28, 2022

Conversation

keu
Copy link
Contributor

@keu keu commented Jan 28, 2022 •
edited
Loading

What

#9768 introduced bug:
dpath.util.get(self._schema, path) does not exist in the test scope because this line of code is from JsonSchemaHelper code.

How

replace with helper.get_node call

Recommended reading order

  1. x.java
  2. y.python

@keu keu linked an issue Jan 28, 2022 that may be closed by this pull request
🐛 SAT: Fix test_oneof_usage fail #9860
Closed
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@keu keu temporarily deployed to more-secrets January 28, 2022 07:17 Inactive
@keu keu temporarily deployed to more-secrets January 28, 2022 10:25 Inactive
keu
keu commented Jan 28, 2022
View reviewed changes
.pre-commit-config.yaml
@@ -11,11 +11,17 @@ repos:
rev: 21.11b1
hooks:
- id: black
args: ["--line-length=140"]
Copy link
Contributor Author

@keu keu Jan 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit config was broken recently, this is the revert

@keu
Copy link
Contributor Author

keu commented Jan 28, 2022 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1761263415
❌ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1761263415

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 28, 2022 11:27 Inactive
@keu
Copy link
Contributor Author

keu commented Jan 28, 2022 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1761371823
❌ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1761371823

@keu keu temporarily deployed to more-secrets January 28, 2022 11:56 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 28, 2022 11:57 Inactive
@eugene-kulak
beatify CHANGELOG.md
e102329
@eugene-kulak
Merge remote-tracking branch 'origin/master' into keu/sat-fix-oneof-t…
6fe5cc7 
…est-9860

# Conflicts:
#	airbyte-integrations/bases/source-acceptance-test/CHANGELOG.md
#	airbyte-integrations/bases/source-acceptance-test/Dockerfile
@keu keu temporarily deployed to more-secrets January 28, 2022 20:59 Inactive
@keu
Copy link
Contributor Author

keu commented Jan 28, 2022 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1763738914
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1763738914

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 28, 2022 21:38 Inactive
@keu keu merged commit d566369 into master Jan 28, 2022
@keu keu deleted the keu/sat-fix-oneof-test-9860 branch January 28, 2022 21:44
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htrueman htrueman htrueman approved these changes

@vitaliizazmic vitaliizazmic vitaliizazmic approved these changes

@augan-rymkhan augan-rymkhan Awaiting requested review from augan-rymkhan

@sergei-solonitcyn sergei-solonitcyn Awaiting requested review from sergei-solonitcyn

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 SAT: Fix test_oneof_usage fail
6 participants
@keu @CLAassistant @htrueman @vitaliizazmic @octavia-squidington-iii @eugene-kulak