Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: Introduce new way to compare records based on PK #9718 #9768

Merged
merged 7 commits into from
Jan 27, 2022

Conversation

keu
Copy link
Contributor

@keu keu commented Jan 24, 2022

What

Read PKs fields and compare records based on their values only
Also, refactored some asserts outside the tests.

How

Use a new serializer in TestFullRefresh if primary keys set.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@keu keu temporarily deployed to more-secrets January 25, 2022 09:33 Inactive
@keu keu temporarily deployed to more-secrets January 25, 2022 10:10 Inactive
@keu keu self-assigned this Jan 25, 2022
@keu keu temporarily deployed to more-secrets January 25, 2022 15:58 Inactive
@keu keu temporarily deployed to more-secrets January 26, 2022 00:56 Inactive
@keu keu requested review from eliziario and removed request for yevhenii-ldv January 26, 2022 01:45
@keu keu requested a review from htrueman January 26, 2022 23:45
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 27, 2022 10:45 Inactive
@keu
Copy link
Contributor Author

keu commented Jan 27, 2022

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1755810431
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1755810431

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 27, 2022 11:00 Inactive
@keu
Copy link
Contributor Author

keu commented Jan 27, 2022

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1756659883
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1756659883

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 27, 2022 14:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAT: Introduce new way to compare records based on PK SAT: refactor JsonSchemaHelper.validate_variant_paths
6 participants