Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source File: Update airbyte-cdk>=0.1.47 to be compatible with latest SAT tests #9974

Merged
merged 3 commits into from
Feb 1, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Feb 1, 2022

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Update airbyte-cdk>=0.1.47 to be compatible with latest SAT tests

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 1, 2022
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets February 1, 2022 17:25 Inactive
@grubberr grubberr changed the title bump version 0.2.8 -> 0.2.9 🎉 Source File: Update airbyte-cdk>=0.1.47 to be compatible with latest SAT tests Feb 1, 2022
@grubberr
Copy link
Contributor Author

grubberr commented Feb 1, 2022

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1779739120
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1779739120
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              275    106    61%
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  70     17    76%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                 1032    415    60%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------------------------------------------
	 source_file/__init__.py       2      0   100%
	 source_file/client.py       237     37    84%
	 source_file/source.py        50     35    30%
	 ---------------------------------------------
	 TOTAL                       289     72    75%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 20 passed, 1 skipped in 16.92s ========================

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 1, 2022 17:30 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grubberr
Please publish these

@grubberr
Copy link
Contributor Author

grubberr commented Feb 1, 2022

/publish connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1779789493
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1779789493

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 1, 2022 17:40 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr merged commit c021426 into master Feb 1, 2022
@grubberr grubberr deleted the grubberr/9782-source-file branch February 1, 2022 17:50
@grubberr grubberr temporarily deployed to more-secrets February 1, 2022 17:51 Inactive
@grubberr grubberr linked an issue Feb 1, 2022 that may be closed by this pull request
@lazebnyi lazebnyi removed their request for review May 30, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update source-file connector to get the latest airbyte_cdk version
3 participants