fix: use rsync for extraPipPackages #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesuperzapper
moved this from Unsorted
to PR | Ready to Merge
in Issue Triage and PR Tracking
thesuperzapper
added
the
status/ready-to-merge
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
thesuperzapper
force-pushed
the
rsync-for-pip-install
branch
from
94ecb9a
to
713057c
Compare
thesuperzapper
changed the title
rsync --delete for extraPipPackages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
What does your PR do?
rsync --deletefor the extraPipPackages init-container, so if the init-container is rerun, any extra existing files on theemptyDirvolume are deleted.rsync --statsarg to highlight to users how much data is being copied (and how fast).Checklist
For all Pull Requests
For releasing ONLY