Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add airflow.protectedPipPackages #610

Merged

Conversation

thesuperzapper
Copy link
Member

What issues does your PR fix?

What does your PR do?

  • Prevents extraPipPackages from changing the version of any pip package listed in airflow.protectedPipPackages.
    • This feature works by adding a pip --constraint file that we generate from the filtered output of pip freeze when installing extraPipPackages.
    • The initial default for airflow.protectedPipPackages is ["apache-airflow"], which will hopefully stop people from accidentally running a different airflow version than specified in their airflow.image.tag.
    • WARNING: if users currently have extraPipPackages configs that are causing their apache-airflow version to be changed, their pods will now crash loop. To resolve this, they will need to remove whatever packages in extraPipPackages were causing the problem.
    • NOTE: users can disable this feature by setting airflow.protectedPipPackages to [], but this is NOT RECOMMENDED as there is probably no situation in which you will want to have extraPipPackages cause an airflow upgrade.

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added this to the airflow-8.6.1 milestone Jun 16, 2022
@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Jun 16, 2022
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Ready to Merge in Issue Triage and PR Tracking Jun 16, 2022
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Jun 16, 2022
@thesuperzapper thesuperzapper merged commit 93a1835 into airflow-helm:main Jun 22, 2022
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done Jun 22, 2022
@thesuperzapper thesuperzapper deleted the protected-pip-packages branch June 22, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant