-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dags.gitSync.submodules
value
#620
feat: add dags.gitSync.submodules
value
#620
Conversation
…oyments Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
@thesuperzapper should I update the version with this as well? would you consider this as a minor version or a patch version? |
This issue has been automatically marked as stale because it has not had activity in 60 days. Thank you for your contributions. Issues never become stale if any of the following is true:
|
@thesuperzapper do you have any plans to merge / release this? |
@karakanb thanks for the PR, don't worry, I haven't forgotten it! As it adds value, it will need to be part of If enough feature PRs build up before then, we might cut |
@thesuperzapper hey Mathew, I hope you are doing well. Do you happen to have a release schedule in mind? it feels like smaller changes like these can go as part of patch versions as long as they are backwards compatible, and would avoid blocking other smaller features until the big ones you'd like to have are ready, as well as avoiding the need to fork by others. Would you be interested in releasing some patch versions with fixes like this, as well as support for newer k8s versions for issues such as #679? |
@karakanb sorry about the delay in getting this PR in a release, I have been busy moving countries! So I can prioritize what to include, what are the critical fixes/features which you would expect in the next release? |
hey, no worries at all. Congrats on the country change, I hope all goes well for you! 🤞 for the next release, the only critical issue I have at the moment is this one: #679 afterwards, if a smaller release brought these that'd be nice
I believe the smaller releases with easy-to-upgrade versions would allow quick iteration + safe rollouts as every change would be gradually adopted by the community instead of bigger / riskier releases in that sense. Thanks a lot for your efforts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karakanb thanks for the PR, there are only a few minor changes (see comments) that I think we need.
Also, we should update the "Load Airflow DAGs" FAQ page to show the new submodules
value in its examples.
dags.gitSync.submodules
value
Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
Signed-off-by: Burak Karakan <burak.karakan@gmail.com>
@thesuperzapper this one is ready as well, please give it a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karakanb thanks for the PR, I will be releasing this today in version 8.7.0
of the chart.
dags.gitSync.submodules
valuedags.gitSync.submodules
value
Signed-off-by: Burak Karakan burak.karakan@gmail.com
What issues does your PR fix?
What does your PR do?
This PR introduces a new value
dags.gitSync.submodules
(default:recursive
) to control the submodule strategy for git-sync pods.In my use case, the repo that is being cloned has a lot of submodules, but I would rather not init the submodules because it takes 20+ seconds, therefore I want to be able to disable the submodules to significantly speed up my tasks.
Checklist
For all Pull Requests
For releasing ONLY