Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow disabling chart-managed webserver_config.py #631

Merged
merged 2 commits into from
Apr 7, 2023
Merged

feat: allow disabling chart-managed webserver_config.py #631

merged 2 commits into from
Apr 7, 2023

Conversation

mb-m
Copy link
Contributor

@mb-m mb-m commented Aug 19, 2022 •
edited by thesuperzapper

What does your PR do?

Allow users to disable the chart-managed webserver_config.py:

  • this can be used when the container image has a webserver_config.py file baked in, or when the user wants to mount the file with a custom volume mount
  • new value web.webserverConfig.enabled (default: true)

feat: allow webserver_config.py to come from the image
07e5bba 
Where you have a webserver_config.py that comes on the image you're using, there needs to be a way to turn it off

Signed-off-by: Matthew Byng-Maddick <mbyng-maddick@olx.com>
@mb-m
Copy link
Contributor Author

mb-m commented Oct 6, 2022

@thesuperzapper now that I see you're back, I'm hoping this is relatively simple to review.

@thesuperzapper
Copy link
Member

@thesuperzapper now that I see you're back, I'm hoping this is relatively simple to review.

@mb-m I never left, lol, I have actually been spending an unbelievable amount of time on #339, I am still hoping to have it in 8.7.0, but if enough useful PRs build up, I will cut 8.7.0 before then.

@thesuperzapper thesuperzapper added this to the airflow-8.6.1 milestone Oct 6, 2022
@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Oct 6, 2022
@mb-m
Copy link
Contributor Author

mb-m commented Oct 7, 2022

@thesuperzapper glad to hear you never left - it seemed like you disappeared for a time - sorry for adding to your obviously heavy workload with this and the other diff (#632) we had been discussing in #629... (I had a further PR which only really works once that latter is merged)

@thesuperzapper thesuperzapper moved this from Unsorted to PR | Ready to Merge in Issue Triage and PR Tracking Apr 5, 2023
@thesuperzapper thesuperzapper added the kind/enhancement kind - new features or changes label Apr 5, 2023
@thesuperzapper thesuperzapper changed the title feat: allow webserver_config.py to come from the image feat: allow disabling chart-managed webserver_config.py Apr 6, 2023
@thesuperzapper
feat: allow disabling chart-managed webserver_config.py
d2809e9 
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added status/ready-to-merge status - this will be merged into next release and removed kind/enhancement kind - new features or changes labels Apr 6, 2023
thesuperzapper
thesuperzapper approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mb-m thanks for the PR, I will be releasing it in chart version 8.7.0 today.

(I pushed a small update to the PR with some docs)

@thesuperzapper thesuperzapper merged commit 9d4362a into airflow-helm:main Apr 7, 2023
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesuperzapper thesuperzapper thesuperzapper approved these changes

Assignees
No one assigned
Labels
status/ready-to-merge status - this will be merged into next release
Projects
Issue Triage and PR Tracking
Done
Milestone
airflow-8.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mb-m @thesuperzapper