-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow disabling chart-managed webserver_config.py
#631
feat: allow disabling chart-managed webserver_config.py
#631
Conversation
Where you have a webserver_config.py that comes on the image you're using, there needs to be a way to turn it off Signed-off-by: Matthew Byng-Maddick <mbyng-maddick@olx.com>
@thesuperzapper now that I see you're back, I'm hoping this is relatively simple to review. |
@mb-m I never left, lol, I have actually been spending an unbelievable amount of time on #339, I am still hoping to have it in 8.7.0, but if enough useful PRs build up, I will cut 8.7.0 before then. |
@thesuperzapper glad to hear you never left - it seemed like you disappeared for a time - sorry for adding to your obviously heavy workload with this and the other diff (#632) we had been discussing in #629... (I had a further PR which only really works once that latter is merged) |
webserver_config.py
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mb-m thanks for the PR, I will be releasing it in chart version 8.7.0
today.
(I pushed a small update to the PR with some docs)
What does your PR do?
Allow users to disable the chart-managed
webserver_config.py
:webserver_config.py
file baked in, or when the user wants to mount the file with a custom volume mountweb.webserverConfig.enabled
(default:true
)