You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When testing for reproducibility at WalletScrutiny, We get a diff in index.html which is caused by the hashed main.js name that forces us to manually compare and review the results. If it's not a technical reason to have bundled main.js name hashed then it would be helpful to disable hashing by adding --output-hashing none when building using ng. like:
ng build --prod --output-hashing none
Or maybe configure ng to use a specific name for bundled files (like using named chunks).
Currently the diff between build and Playstore APK looks like:
diff --recursive /tmp/fromPlay_it.airgap.vault_51797 /tmp/fromBuild_it.airgap.vault_51797
diff --recursive /tmp/fromPlay_it.airgap.vault_51797/assets/public/index.html /tmp/fromBuild_it.airgap.vault_51797/assets/public/index.html
40c40
< <script src="runtime.14f2a6f1540aae4d.js" type="module"></script><script src="polyfills.5110c1e93db6f937.js" type="module"></script><script src="main.bc1e4e3a4f2da280.js" type="module"></script>
---
> <script src="runtime.14f2a6f1540aae4d.js" type="module"></script><script src="polyfills.5110c1e93db6f937.js" type="module"></script><script src="main.5184e2029b8e7e07.js" type="module"></script>
Only in /tmp/fromBuild_it.airgap.vault_51797/assets/public: main.5184e2029b8e7e07.js
Only in /tmp/fromPlay_it.airgap.vault_51797/assets/public: main.bc1e4e3a4f2da280.js
Only in /tmp/fromPlay_it.airgap.vault_51797/META-INF: MANIFEST.MF
Only in /tmp/fromPlay_it.airgap.vault_51797/META-INF: PAPERS.RSA
Only in /tmp/fromPlay_it.airgap.vault_51797/META-INF: PAPERS.SF
I don't think we need the hashed names. But turning it off will not solve the underlying issue of the main.js file not being the same. I did some quick research about this tslint_awaiter and I didn't find what the cause for this could be. Maybe the environment is not exactly the same? To reproduce the apk, do you have exactly the same node version and global dependencies that we use in our Dockerfile?
On Wed, Jun 21, 2023, 3:23 PM AndreasGassmann ***@***.***> wrote:
Hi, thanks for opening this issue.
I don't think we need the hashed names. But turning it off will not solve
the underlying issue of the main.js file not being the same. I did some
quick research about this tslint_awaiter and I didn't find what the cause
for this could be. Maybe the environment is not exactly the same? To
reproduce the apk, do you have exactly the same node version and global
dependencies that we use in our Dockerfile?
—
Reply to this email directly, view it on GitHub
<#197 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTM4ZFNMHJPBZIW7OYJTN3XMLOEVANCNFSM6AAAAAAZNZALFY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
Well we use your docker file located on build/android to build the project. So everything should be same. Do you use the same Dockerfile to build production apk?
When testing for reproducibility at WalletScrutiny, We get a diff in index.html which is caused by the hashed main.js name that forces us to manually compare and review the results. If it's not a technical reason to have bundled main.js name hashed then it would be helpful to disable hashing by adding
--output-hashing none
when building using ng. like:Or maybe configure ng to use a specific name for bundled files (like using named chunks).
Currently the diff between build and Playstore APK looks like:
Also there is a minor diff in main.*.js files:
The text was updated successfully, but these errors were encountered: