Use Unsafe to obtain location of direct Buffer address field #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
directbuffer-take-2
branch
2 times, most recently
from
fae442f
to
3e4ad51
Compare
Java 16 removed reflective access to internal fields in the java.nio.Buffer class to be able to operate on direct byte buffers, so resort to Unsafe as a stop gap. We'll revisit this later, possibly when the Foreign-Memory Access API becomes final.
martint
force-pushed
the
directbuffer-take-2
branch
from
3e4ad51
to
b3f19d4
Compare
electrum
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 16 removed reflective access to internal fields in the java.nio.Buffer class
to be able to operate on direct byte buffers, so resort to Unsafe as a stop gap.
We'll revisit this later, possibly when the Foreign-Memory Access API
becomes final.
Fixes #125