-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Netmanager] Device recallType implementations #1415
Conversation
New netmanager changes available for preview here |
2 similar comments
New netmanager changes available for preview here |
New netmanager changes available for preview here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I had added a commit to the previous pr which involves reloading the page whenever someone deploys or recalls so as to reload the device data but it has not been added to this, kindly check for that functionality in your old pr and add it.
-
The recall button UI can be improved. The selection input should only appear when a user clicks recall device. Suggesting we use a pop up as initially designed by Daniel to avoid any confusion. cc @Baalmart
-
Tests for this pr are missing too.
New netmanager changes available for preview here |
4 similar comments
New netmanager changes available for preview here |
New netmanager changes available for preview here |
New netmanager changes available for preview here |
New netmanager changes available for preview here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here! LGTM @danielmarv
Summary of Changes (What does this PR do?)
i have added new columns to the Network activties Logs table
i have also updated the react-redux for the tests success
Status of maturity (all need to be checked before merging):
What are the relevant tickets?
Screenshots (optional)