Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Netmanager] Device recallType implementations #1415

Merged
merged 10 commits into from
Aug 14, 2023
Merged

[Netmanager] Device recallType implementations #1415

merged 10 commits into from
Aug 14, 2023

Conversation

danielmarv
Copy link
Member

Summary of Changes (What does this PR do?)

  • Adding some fields to the Network activities ie ;
  1. userName
  2. firstName
  3. lastName
  4. email
  • i have also added the the recallType on recalling the device ie;

errors
disconnected

  • i have added new columns to the Network activties Logs table

  • i have also updated the react-redux for the tests success

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

What are the relevant tickets?

Screenshots (optional)

@danielmarv
Copy link
Member Author

In this PR now every thing is up to date and included everything that is needed
CC @Codebmk @Baalmart

@danielmarv danielmarv changed the title Net recall [Netmanager] Device recallType implementations Aug 14, 2023
@github-actions
Copy link
Contributor

New netmanager changes available for preview here

2 similar comments
@github-actions
Copy link
Contributor

New netmanager changes available for preview here

@github-actions
Copy link
Contributor

New netmanager changes available for preview here

Copy link
Member

@Codebmk Codebmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I had added a commit to the previous pr which involves reloading the page whenever someone deploys or recalls so as to reload the device data but it has not been added to this, kindly check for that functionality in your old pr and add it.

  2. The recall button UI can be improved. The selection input should only appear when a user clicks recall device. Suggesting we use a pop up as initially designed by Daniel to avoid any confusion. cc @Baalmart
    image

  3. Tests for this pr are missing too.

@github-actions
Copy link
Contributor

New netmanager changes available for preview here

4 similar comments
@github-actions
Copy link
Contributor

New netmanager changes available for preview here

@github-actions
Copy link
Contributor

New netmanager changes available for preview here

@github-actions
Copy link
Contributor

New netmanager changes available for preview here

@github-actions
Copy link
Contributor

New netmanager changes available for preview here

Copy link
Member

@Codebmk Codebmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here! LGTM @danielmarv

@Baalmart Baalmart merged commit 5433c08 into staging Aug 14, 2023
21 checks passed
@Baalmart Baalmart deleted the Net-Recall branch August 14, 2023 21:14
@Baalmart Baalmart mentioned this pull request Aug 14, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants