Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Netmanager] Sessions Timeout For user login #1416

Merged
merged 8 commits into from
Aug 16, 2023
Merged

Conversation

danielmarv
Copy link
Member

@danielmarv danielmarv commented Aug 14, 2023

Summary of Changes (What does this PR do?)

  • i have triggered session timeout for the users when there is inactivity for 30 Minutes
  • I have failed to include the tests because of some unmet dependencies in the staging of which am not the cause.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

What are the relevant tickets?

Screenshots (optional)

@github-actions
Copy link
Contributor

New netmanager changes available for preview here

1 similar comment
@github-actions
Copy link
Contributor

New netmanager changes available for preview here

Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @danielmarv for the amazing work!
I will test out and share feedback as soon as possible.

Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the unit tests, they are now mandatory...so please resolve those "unmet" dependencies accordingly. @danielmarv

Testing the Session timeout functionality with Enzyme
@danielmarv
Copy link
Member Author

but as for the functionality is everything ok no any changes needed????

@github-actions
Copy link
Contributor

New netmanager changes available for preview here

@Baalmart
Copy link
Collaborator

here

@danielmarv
I have just logged in, I am now waiting to be logged out.
Will share feedback shortly

@danielmarv
Copy link
Member Author

but it with out user activity so it is set to 30 minutes with out any activity
if you do any activity on the platform it reset the timer

@danielmarv
Copy link
Member Author

or i first reduce the duration to stop time wastage

@Baalmart
Copy link
Collaborator

Hi @danielmarv
Not sure but I am still logged into the system after 30 mins elapsed. How is one supposed to test out this PR?

@danielmarv
Copy link
Member Author

login but without any activity after the 30 minutes elapse it will auto matically log you out
but i can reduce the time period for the testing because that takes time and after i take it back to normal

@danielmarv
Copy link
Member Author

because me i have tested it locally

@danielmarv
Copy link
Member Author

i have reduced the time period to 30 seconds now it has logged me out of the system
logout

@danielmarv
Copy link
Member Author

because you cannot logout a user when he/she is actively using the system but you can logout an inactive logged in user

@Baalmart
Copy link
Collaborator

i have reduced the time period to 30 seconds now it has logged me out of the system logout

Hi @danielmarv .....30 seconds is too short. You can put it back to 10 mins then. Thanks!

@Baalmart Baalmart merged commit 3f3afd0 into staging Aug 16, 2023
21 checks passed
@Baalmart Baalmart deleted the NET-timeout-sessions branch August 16, 2023 07:36
@Baalmart Baalmart mentioned this pull request Aug 16, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants