Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the inital implementation of Account Linking #2001

Merged
merged 2 commits into from May 9, 2024

Conversation

katendejericho5
Copy link
Contributor

@katendejericho5 katendejericho5 commented May 9, 2024

Summary of Changes (What does this PR do?)

  • I have removed the current account linking functionality

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included issue number in the "Closes #ISSUE-NUMBER" part of the "What are the relevant tickets?" section to link the issue.
  • I've updated corresponding documentation for the changes in this PR.
  • I have written unit and/or e2e tests for my change(s).

How should this be manually tested?

  • Please include the steps to be done inorder to setup and test this PR.

What are the relevant tickets?

Screenshots (optional)

@katendejericho5 katendejericho5 self-assigned this May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 4.76190% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 7.90%. Comparing base (a42919e) to head (2371947).
Report is 20 commits behind head on staging.

Files Patch % Lines
mobile/lib/screens/home_page.dart 0.00% 22 Missing ⚠️
...mail_authentication/email_verification_screen.dart 0.00% 9 Missing ⚠️
mobile/lib/screens/profile/profile_widgets.dart 28.57% 5 Missing ⚠️
mobile/lib/screens/profile/profile_edit_page.dart 0.00% 3 Missing ⚠️
mobile/lib/screens/profile/profile_view.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging   #2001       +/-   ##
===========================================
- Coverage    37.33%   7.90%   -29.44%     
===========================================
  Files           59     165      +106     
  Lines          616   11772    +11156     
  Branches       121       0      -121     
===========================================
+ Hits           230     930      +700     
- Misses         367   10842    +10475     
+ Partials        19       0       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baalmart Baalmart merged commit 001d6d7 into staging May 9, 2024
27 of 31 checks passed
@Baalmart Baalmart deleted the disable-account-linking branch May 9, 2024 18:07
@Baalmart Baalmart mentioned this pull request May 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants