Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPG Sops integration issues with gate #378

Closed
eak13 opened this issue Oct 27, 2020 · 8 comments
Closed

GPG Sops integration issues with gate #378

eak13 opened this issue Oct 27, 2020 · 8 comments
Assignees
@udayruddarraju
Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release
Milestone
v2.0

Comments

@eak13
Copy link

eak13 commented Oct 27, 2020 •
edited
Loading

Describe the bug
The introduction of GPG Sops integration to handle secret encryption/decryption is now causing other patchsets to fail the gating tests at airship-airshipctl-lint-unit.

These are the patchsets causing the issue:

Example patchsets failing the gate:

This issue is to provide temporary remediation to fix the gating issues with the current design & create mock tests to bypass these gpg issues.
@eak13 eak13 added bug Something isn't working triage Needs evaluation by project members labels Oct 27, 2020
@michaelfix
Copy link

@cloudstarz - Uday, please ack. receipt, add comment, and we can add you as an assignee.

@udayruddarraju
Copy link
Contributor

Hey all, I am working on this right now. This is being a little tricky to investigate and is very flaky, but we believe an old gpg version is the culprit here and will keep this issue posted

@udayruddarraju
Copy link
Contributor

Work in progress patchset here: https://review.opendev.org/#/c/759918

@udayruddarraju
Copy link
Contributor

udayruddarraju commented Oct 29, 2020 •
edited
Loading

Created getsops/sops#762 to be able to better understand the underlying issues we are with sops when sops tries to generate a data key used for encryption. The patchset linked above fixes one bug with the key cleanup that has caused the Decrypt tests to fail in the above patchsets: https://zuul.opendev.org/t/openstack/build/7340036b446d4bcc952f3e9bda17510d

cc @mattmceuen @teoyaomiqui

@jezogwza jezogwza removed the triage Needs evaluation by project members label Nov 4, 2020
@jezogwza jezogwza added this to the v2.0 milestone Nov 4, 2020
@jezogwza jezogwza added the priority/critical Items critical to be implemented, usually by the next release label Nov 4, 2020
@teoyaomiqui
Copy link
Contributor

teoyaomiqui commented Nov 5, 2020 •
edited
Loading

related patchset https://review.opendev.org/#/c/761610/1

airshipbot pushed a commit that referenced this issue Nov 5, 2020
@SirishaGopigiri
Revert "Encrypt and decrypt using sops"
f705ff0 
This reverts commit 9a608de.

Requesting revert because of the sops+gpg testcase failure issues. The failed testcases are impacting airship-airshipctl-lint-unit zuul gate.

For more details please refer to #378

Change-Id: I60f6b5daaeebc038b68556c60413b3d0c6db6d68
@eak13
Copy link
Author

eak13 commented Jan 11, 2021

@teoyaomiqui with https://review.opendev.org/c/airship/airshipctl/+/761610/ getting merged, can we go ahead and close this issue out?

@teoyaomiqui
Copy link
Contributor

@ak3216 I think so, yes

@eak13
Copy link
Author

eak13 commented Jan 11, 2021

Closing per code merge

@eak13 eak13 closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@udayruddarraju udayruddarraju

Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
5 participants
@michaelfix @eak13 @jezogwza @teoyaomiqui @udayruddarraju