Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airshipctl config get-credentials has unpredictable output #48

Closed
ian-howell opened this issue Feb 17, 2020 · 2 comments
Closed

airshipctl config get-credentials has unpredictable output #48

ian-howell opened this issue Feb 17, 2020 · 2 comments
Assignees
@ian-howell
Labels
3-Container Relates to plugin related issues bug Something isn't working cli Relates to configuration or code for the CLI

Comments

@ian-howell
Copy link
Contributor

Describe the bug
The airshipctl config get-credentials command outputs the credentials in random order. This could be confusing to a user who expects consistent output. It also causes issues with unit tests; tests will frequently pass, but occasionally fail.

Steps To Reproduce
Create an airship config with multiple credentials and run airshipctl config get-credentials several times.

Expected behavior
Output should be the same every time.
@ian-howell ian-howell added bug Something isn't working triage Needs evaluation by project members labels Feb 17, 2020
@ian-howell ian-howell self-assigned this Feb 17, 2020
@ian-howell ian-howell added cli Relates to configuration or code for the CLI 3-Container Relates to plugin related issues wip Work in progress ready for review Change related to the issue is ready for review and removed wip Work in progress labels Feb 17, 2020
@ian-howell
Copy link
Contributor Author

Patchset

airshipbot pushed a commit that referenced this issue Feb 17, 2020
@ian-howell
[#48] Make output from config get-* uniform
46f5c63 
This changes the output of the get-cluster, get-context, and
get-credentials subcommands to be uniform across multiple runs of the
program. This allows for predictable output for users and a controlled
environment for testing.

Change-Id: If87ec50b9d65750565a204514d6b647be64bb30d
@ianpittwood ianpittwood removed the triage Needs evaluation by project members label Feb 17, 2020
@ianpittwood ianpittwood removed the ready for review Change related to the issue is ready for review label Feb 18, 2020
@jezogwza jezogwza mentioned this issue Apr 8, 2020
Closed
@airshipbot
Copy link

The Change that closes this issue was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ian-howell ian-howell

Labels
3-Container Relates to plugin related issues bug Something isn't working cli Relates to configuration or code for the CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ianpittwood @ian-howell @airshipbot