-
Notifications
You must be signed in to change notification settings - Fork 234
Complete Rebranding #476
Comments
I think before we do a rebrand, it might make sense to try to get any large PR's we have merged in so that we can reduce the amount of duplicated effort. @biconou perhaps your jukebox PR should go in? I would also like to get in the REST api changes as well. |
Agree.
I'll re-create the jukebox PR last week as I'll be in vacation next days.
…On 04/07/2017 22:03, Andrew DeMaria wrote:
I think before we do a rebrand, it might make sense to try to get any
large PR's we have merged in so that we can reduce the amount of
duplicated effort. @biconou <https://github.com/biconou> perhaps your
jukebox PR should go in? I would also like to get in the REST api
changes as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#476 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFTqs27irPOewKRdWer92_6DFm5FWgrKks5sKpqLgaJpZM4ONpzF>.
|
Is there any link to discussion why another fork was created? |
@Tapchicoma The original discussion was on IRC:
There was a reddit discussion about the IRC converstation, but it has since been deleted. Due to all our communication channels being under control by Eugene, a couple of us discussed things out-of-band which aren't really linkable to. The plan is to create a document with the above IRC snippet and why a fork was necessary under the history section of the main Readme. |
I create a PR for the new jukebox #477 and tested it. |
Cool, I'll try and pull it in asap. Also looks like we need to resetup the build checker. |
Do you mean Travis ? |
right |
Ah, I see. I don't know why the open source community is absolutely LITTERED with people like that. It is completely against what open source is all about and leads to terrible project fragmentation. A while back I tried to contribute to mplayer and mplayer2 and made a bugfix that fixed a broken VFW codec in them that previously crashed the player but those people were absolute nightmares to work with and so my fix is still not there to this day lol. Best of luck to this fork! I will hopefully be able to make some contributions at some point, but I'm looking to be very busy for at least the next half year or so. |
I created #483 for the rebrand. |
100% on board. Eugene is the reason I stopped contributing to Libresonic. Now that there are some people besides myself who want to see a completely community driven project I will happily jump back on board! |
Right on guys! |
We made a pretty good start ! Let's close this ! |
Some items to finish the rebrand:
The text was updated successfully, but these errors were encountered: