Merge pull request #322 from airswap/buffer-to-hex-sigs

Converting buffer to hex for ecsign signatures
airswap · Nov 25, 2019 · d339abf · d339abf
2 parents 401c447 + 90a1d2c
commit d339abf
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 10 deletions.
diff --git a/source/delegate-factory/package.json b/source/delegate-factory/package.json
@@ -21,7 +21,7 @@
     "verify": "truffle run verify"
   },
   "devDependencies": {
-    "@airswap/order-utils": "0.3.9",
+    "@airswap/order-utils": "0.3.10",
     "@airswap/test-utils": "0.1.1",
     "solidity-coverage": "^0.6.3"
   },

diff --git a/source/delegate/package.json b/source/delegate/package.json
@@ -21,7 +21,7 @@
     "verify": "truffle run verify"
   },
   "devDependencies": {
-    "@airswap/order-utils": "0.3.9",
+    "@airswap/order-utils": "0.3.10",
     "@airswap/test-utils": "0.1.1",
     "solidity-coverage": "^0.6.3"
   },

diff --git a/source/index/package.json b/source/index/package.json
@@ -21,7 +21,7 @@
     "verify": "truffle run verify"
   },
   "devDependencies": {
-    "@airswap/order-utils": "0.3.9",
+    "@airswap/order-utils": "0.3.10",
     "@airswap/test-utils": "0.1.1",
     "@airswap/tokens": "0.1.3",
     "bignumber.js": "^9.0.0",

diff --git a/source/indexer/package.json b/source/indexer/package.json
@@ -22,7 +22,7 @@
   },
   "devDependencies": {
     "@airswap/index": "0.3.2",
-    "@airswap/order-utils": "0.3.9",
+    "@airswap/order-utils": "0.3.10",
     "@airswap/test-utils": "0.1.1",
     "@airswap/types": "0.4.3",
     "bignumber.js": "^9.0.0",

diff --git a/source/swap/package.json b/source/swap/package.json
@@ -22,7 +22,7 @@
   },
   "devDependencies": {
     "@airswap/tokens": "0.1.3",
-    "@airswap/order-utils": "0.3.9",
+    "@airswap/order-utils": "0.3.10",
     "@airswap/test-utils": "0.1.1",
     "truffle": "^5.0.32",
     "@gnosis.pm/mock-contract": "^3.0.7",

diff --git a/source/types/package.json b/source/types/package.json
@@ -22,7 +22,7 @@
   },
   "devDependencies": {
     "@airswap/tokens": "0.1.3",
-    "@airswap/order-utils": "0.3.9",
+    "@airswap/order-utils": "0.3.10",
     "solidity-coverage": "^0.6.3"
   },
   "dependencies": {

diff --git a/source/wrapper/package.json b/source/wrapper/package.json
@@ -22,7 +22,7 @@
     "verify": "truffle run verify"
   },
   "devDependencies": {
-    "@airswap/order-utils": "0.3.9",
+    "@airswap/order-utils": "0.3.10",
     "@airswap/test-utils": "0.1.1",
     "solidity-coverage": "^0.6.3"
   },

diff --git a/utils/order-utils/package.json b/utils/order-utils/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@airswap/order-utils",
-  "version": "0.3.9",
+  "version": "0.3.10",
   "description": "JavaScript utilities for orders, hashes, and signatures in the Swap Protocol",
   "license": "Apache-2.0",
   "repository": {

diff --git a/utils/order-utils/src/signatures.js b/utils/order-utils/src/signatures.js
@@ -52,8 +52,8 @@ module.exports = {
       validator: verifyingContract,
       version: signatures.SIGN_TYPED_DATA,
       v,
-      r,
-      s,
+      r: ethUtil.bufferToHex(r),
+      s: ethUtil.bufferToHex(s),
     }
   },
   getPersonalSignature(order, privateKey, verifyingContract) {