Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting buffer to hex for ecsign signatures #322

Merged
merged 3 commits into from Nov 25, 2019
Merged

Converting buffer to hex for ecsign signatures #322

merged 3 commits into from Nov 25, 2019

Conversation

dmosites
Copy link
Contributor

Description

ecsign was returning Buffer instead of hex.

  • N/A
  • New features
  • Bug fixes
  • Typo/small tweaks

poiresel
poiresel reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@poiresel poiresel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does a similar behavior need to be in getWeb3Signature?

@dmosites
Copy link
Contributor Author

does a similar behavior need to be in getWeb3Signature?

No because ethUtil.fromRpcSig does the conversion.

@dmosites dmosites merged commit d339abf into master Nov 25, 2019
@dmosites dmosites deleted the buffer-to-hex-sigs branch December 3, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poiresel poiresel poiresel left review comments

@perich perich perich approved these changes

@hensha256 hensha256 hensha256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmosites @poiresel @perich @hensha256