Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @httptoolkit/osx-find-executable 2.x #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Krinkle
Copy link

@Krinkle Krinkle commented Apr 28, 2023

The previous version emits an npm-audit warning, for the change at httptoolkit/osx-find-executable@20fb1e2c, which is a breaking change that can't be patched downstream as it is incompatible with the current way the function is called.

It appears this repo has no tests.

Test plan:

  • node -e "require('./index.js').detect(console.log)" before/after the change, no difference in output.

lib/detect/darwin.js Outdated Show resolved Hide resolved
The previous version emits an npm-audit warning, for the change
at httptoolkit/osx-find-executable@20fb1e2c,
which is a breaking change that can't be patched downstream as it
is incompatible with the current way the function is called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants