Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust phone number user input #1681

Closed
chrismatix opened this issue Apr 29, 2021 · 0 comments · Fixed by #1772
Closed

Robust phone number user input #1681

chrismatix opened this issue Apr 29, 2021 · 0 comments · Fixed by #1772
Assignees
Labels

Comments

@chrismatix
Copy link
Contributor

Current state

Users can supply phone numbers for Twilio Sms and Whatsapp. We use these as a sourceConversationId and match it with incoming Webhook data from Twilio.

However, sometimes users may enter their phone numbers with spaces e.g. "+49 123 456 789", which will cause this exact match to fail.

Desired state

The Twilio channel connectors properly normalize the input before storing the channel.

@chrismatix chrismatix added this to To do in Engineering WIP via automation Apr 29, 2021
@chrismatix chrismatix self-assigned this Apr 29, 2021
@chrismatix chrismatix moved this from To do to In progress in Engineering WIP May 10, 2021
chrismatix pushed a commit that referenced this issue May 11, 2021
Engineering WIP automation moved this from In progress to Done May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

1 participant