Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect root request to /ui #1939

Closed
ljupcovangelski opened this issue Jun 7, 2021 · 4 comments
Closed

Redirect root request to /ui #1939

ljupcovangelski opened this issue Jun 7, 2021 · 4 comments
Assignees
@ljupcovangelski
Labels
infrastructure
Projects
Engineering WIP

Comments

@ljupcovangelski
Copy link
Contributor

On the default installation, when one tries to access the root path, he gets a 404 page not found.
As we don't use that path, we can redirect it to /ui so that the Inbox can be accessible directly on http://airy.core or whatever other hostname that is used.
@ljupcovangelski ljupcovangelski added this to To do in Engineering WIP via automation Jun 7, 2021
@ljupcovangelski ljupcovangelski moved this from To do to In progress in Engineering WIP Jun 7, 2021
@ljupcovangelski ljupcovangelski changed the title Redirect root path to /ui Redirect root request to /ui Jun 7, 2021
ljupcovangelski added a commit that referenced this issue Jun 7, 2021
@ljupcovangelski
[#1939] Redirect root request to /ui
7dc9b81
ljupcovangelski added a commit that referenced this issue Jun 8, 2021
@ljupcovangelski
[#1939] Redirect root request to /ui (#1940)
1d2350c
@ljupcovangelski
Copy link
Contributor Author

Done.

Engineering WIP automation moved this from In progress to Done Jun 8, 2021
@chrismatix chrismatix reopened this Jun 11, 2021
Engineering WIP automation moved this from Done to In progress Jun 11, 2021
chrismatix added a commit that referenced this issue Jun 11, 2021
@chrismatix
Revert "[#1939] Redirect root request to /ui (#1940)"
06b06f8 
This reverts commit 1d2350c.
ljupcovangelski pushed a commit that referenced this issue Jun 11, 2021
@chrismatix
Revert "[#1939] Redirect root request to /ui (#1940)" (#1969)
e6945eb 
This reverts commit 1d2350c.
@ljupcovangelski ljupcovangelski moved this from In progress to To do in Engineering WIP Jun 14, 2021
@ljupcovangelski ljupcovangelski moved this from To do to In progress in Engineering WIP Jun 15, 2021
ljupcovangelski added a commit that referenced this issue Jun 16, 2021
@ljupcovangelski
[#1939] Redirect / to /ui
1934ca7
ljupcovangelski added a commit that referenced this issue Jun 16, 2021
@ljupcovangelski
[#1939] Redirect / to /ui (#2001)
9b722a9
@ljupcovangelski
Copy link
Contributor Author

We needed to add one more ingress resource because of the StripPrefixSettings in the airy-core-ui ingress.

Engineering WIP automation moved this from In progress to Done Jun 16, 2021
@ljupcovangelski
Copy link
Contributor Author

Currently the redirect works for all requests which are not specified. We should rework the redirect, to apply only for when root path is called - / and not for the other random requests.

Particularly the redirect must not work for POST requests sent to the API, even those for which the paths are missing in the ingress. Also the path for the the API request can be changed to /api.

@ljupcovangelski
Copy link
Contributor Author

With the latest ingress controller change, it works now only for the / path and not for all the other non-existent paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljupcovangelski ljupcovangelski

Labels
infrastructure
Projects
Engineering WIP
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrismatix @ljupcovangelski