Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make windows airy create work #1952

Open
2 tasks
chrismatix opened this issue Jun 9, 2021 · 3 comments
Open
2 tasks

Make windows airy create work #1952

chrismatix opened this issue Jun 9, 2021 · 3 comments

Comments

@chrismatix
Copy link
Contributor

Current state

We build and provide CLI binaries for Windows, but have sofar not tested them or invested any development effort into making them work.

image
(thanks to @Decmcc for the screenshot)

Desired state

We don't want to officially support windows for a lack of capacity and developer share.

As an airy user
Given that I have downloaded the windows CLI binary
When I run the create --provider minikube command
Then I have a working minikube installation with support for cli commands

TODO:

  • Implement user story
  • Update docs to say that windows is supported unofficially
@chrismatix chrismatix added the cli label Jun 9, 2021
@chrismatix chrismatix changed the title Make windows create work Make windows airy create work Jun 9, 2021
@ljupcovangelski
Copy link
Contributor

The problem with airy create on Windows is because the path of embedded file is read wrong. This line causes problem
https://github.com/airyhq/airy/blob/develop/cli/pkg/workspace/template/copy.go#L43

Even though bazel builds it correctly for Windows with "" instead of what is the default for *nix "/".

I tested with

content, err := templateDir.ReadFile("src/airy.yaml")

and it works correctly.

Also in the embed package, they have stated that: The path separator is a forward slash, even on Windows systems.

@chrismatix
Copy link
Contributor Author

@ljupcovangelski That's very interesting. It means that we are reading the embedded directory wrong, because we use filepath.join which seems to use OS-specific path delimiters.

So to fix this we need to recursively list the template directory without relying on that method.

@ljupcovangelski
Copy link
Contributor

The embedded path was fixed and now airy create starts the provisioning on Windows. However, I was still getting some issues when the helm chart is deployed, that the images cannot be pulled

Failed to pullimage "busybox": rpc error: code = Unknown desc = Error response from daemon: Get https://registry-1.docker.io/v2/: dial tcp: lookup registry-1.docker.io on 10.0.2.3:53 read udp i/o timeout

It needs some more testing and debugging.

@ljupcovangelski ljupcovangelski moved this from In progress to To do in Engineering WIP Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants