Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-organizing Infinite Scroll for ConversationList and MessageList #1991

Closed
AudreyKj opened this issue Jun 15, 2021 · 1 comment · Fixed by #2006
Closed

Re-organizing Infinite Scroll for ConversationList and MessageList #1991

AudreyKj opened this issue Jun 15, 2021 · 1 comment · Fixed by #2006
Assignees
@AudreyKj
Labels
bug frontend inbox
Projects
Engineering WIP

Comments

@AudreyKj
Copy link
Contributor

AudreyKj commented Jun 15, 2021 •
edited
Loading

Current state

  • we have an architecture problem regarding infinite scrolling for messages and conversations
  • the way we pass props is also problematic: we pass too much data to the components, we need to fine-grain the way we pass props

To do

  • investigate ways we can improve the infinite loading of messages and conversations as well as the way we pass props
@AudreyKj
Copy link
Contributor Author

AudreyKj commented Jun 15, 2021 •
edited
Loading

@AudreyKj AudreyKj self-assigned this Jun 16, 2021
@AudreyKj AudreyKj added this to To do in Engineering WIP via automation Jun 16, 2021
@AudreyKj AudreyKj moved this from To do to In progress in Engineering WIP Jun 16, 2021
@AudreyKj AudreyKj mentioned this issue Jun 16, 2021
Merged
Engineering WIP automation moved this from In progress to Done Jun 21, 2021
AudreyKj added a commit that referenced this issue Jun 21, 2021
@AudreyKj
[#1991] re-organizing infinite scroll for conversationlist and messag…
6fd7175 
…elist (#2006)

* infinite scroll from scratch for conversation list

* conversation list from scratch - working version

* removed npm package and unecessary code related to react window

* removed react window dependency

* fine-grained props in messagelist

* refactored implementation and fixed ui conversation list

* linting

* refactored fetching of conversations in list

* removed logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AudreyKj AudreyKj

Labels
bug frontend inbox
Projects
Engineering WIP
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1991] re-organizing infinite scroll for conversationlist and messagelist airyhq/airy
1 participant
@AudreyKj