Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Commas to Inbox Conversation Count #2005

Closed
lizhutter opened this issue Jun 16, 2021 · 5 comments
Closed

Add Commas to Inbox Conversation Count #2005

lizhutter opened this issue Jun 16, 2021 · 5 comments

Comments

@lizhutter
Copy link
Contributor

Currently:

The Inbox conversation count looks like the image below:

Screenshot 2021-06-16 at 10 48 33

In addition to this, the conversation count visible within the tab appears the same way:

Screenshot 2021-06-16 at 10 48 41

Requirements

We should put a comma when there are more than a thousand conversations. Whether it is 1,000 or 1,000,000 -- we should be able to successfully include these commas.

@lizhutter lizhutter added good first issue Good for newcomers inbox labels Jun 16, 2021
@brennanw31
Copy link

Could I give this a try?

@lizhutter
Copy link
Contributor Author

@brennanw31 Absolutely, let me know if you have any questions!

@brennanw31
Copy link

@lizhutter Sorry I'm very new to GitHub, could you direct me to the file destination of the code regarding the issue?

@AitorAlgorta
Copy link
Contributor

Hey @brennanw31 I can help with this. We have a component called InboxConversationCount that you can find under frontend/ui/src/pages/Inbox/ConversationListHeader, there is where the fix is needed. Let me know if you need more help and looking forward to approve your pull request :)

@lizhutter lizhutter added this to To do in Engineering WIP via automation Nov 5, 2021
@lizhutter lizhutter added enhancement and removed good first issue Good for newcomers labels Nov 5, 2021
@AudreyKj AudreyKj self-assigned this Nov 18, 2021
@AudreyKj AudreyKj moved this from To do to In progress in Engineering WIP Nov 18, 2021
@AudreyKj AudreyKj moved this from In progress to Done in Engineering WIP Nov 19, 2021
@AudreyKj
Copy link
Contributor

fixed by #2606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants