New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2591] inbox counter not updating properly #2606
[#2591] inbox counter not updating properly #2606
Conversation
@@ -9,7 +9,7 @@ | |||
padding-top: 88px; | |||
width: 100%; | |||
padding: 32px; | |||
margin: 88px 1.5em 0 100px; | |||
margin: 88px 1.5em 0 16px; | |||
min-height: calc(100vh - 170px); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IG channel UI fix
if (Object.entries(currentFilter).length !== 0) { | ||
setFilter(currentFilter); | ||
} | ||
|
||
setButtonStateEnabled(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed counter not updating when changing state on filtering conversations
: formatConversationCount(filteredPaginationData.total) | ||
})` | ||
); | ||
}, [totalConversations, filteredPaginationData.total]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed counter not updating in the tab
@@ -0,0 +1,3 @@ | |||
export function formatConversationCount(count: number): string { | |||
return Intl.NumberFormat('en-US').format(count); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting of the inbox counter number (#2005)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #2591 + #2528 + #2005