Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display name update bug #3192

Closed
AudreyKj opened this issue May 24, 2022 · 2 comments · Fixed by #3203
Closed

Display name update bug #3192

AudreyKj opened this issue May 24, 2022 · 2 comments · Fixed by #3203
Assignees
Labels

Comments

@AudreyKj
Copy link
Contributor

AudreyKj commented May 24, 2022

Current state:
at the moment, we have 2 display names for contacts: there is one displayName in conversation.metadata and one displayName in contacts

The problem is that these 2 infos can get out of sync: for example, when the user updates the display name on the conversation UI (in Inbox), the display name in conversation.metadata gets updated but not the display name in contacts.

We can fix this by updating both informations when the user updates the display name on the conversation UI (in Inbox)

@AudreyKj AudreyKj self-assigned this May 24, 2022
@AudreyKj AudreyKj added the bug label May 24, 2022
@chrismatix
Copy link
Contributor

chrismatix commented May 24, 2022

This is on purpose since different sources may contribute different source names.

We can fix this by updating both informations when the user updates the display name on the UI.

This is when the user updates the display name on the conversation UI, correct?

@AudreyKj
Copy link
Contributor Author

AudreyKj commented May 24, 2022

@chrismatix

yes I was thinking of fixing it like this in the frontend to avoid discrepancies when the display name is updated.

AudreyKj added a commit that referenced this issue May 25, 2022
* update contacts update

* fixed contacts update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants