Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1068] improve channels UI #1071

Merged
merged 6 commits into from Feb 24, 2021
Merged

[#1068] improve channels UI #1071

merged 6 commits into from Feb 24, 2021

Conversation

AitorAlgorta
Copy link
Contributor

resolves #1068

@AitorAlgorta AitorAlgorta marked this pull request as draft February 23, 2021 14:04
@github-actions github-actions bot added the fix label Feb 23, 2021
stayprodio
stayprodio approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@stayprodio stayprodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AitorAlgorta AitorAlgorta marked this pull request as ready for review February 23, 2021 14:30
bitboxer
bitboxer reviewed Feb 24, 2021
View reviewed changes
Copy link
Contributor

@bitboxer bitboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I have one little question :)

frontend/ui/src/pages/Channels/ChannelsSources/GoogleSource.tsx Outdated Show resolved Hide resolved
@AitorAlgorta AitorAlgorta merged commit 6cb3e47 into develop Feb 24, 2021
@AitorAlgorta AitorAlgorta deleted the fix/1068-ui-fixes-channels-main-page branch February 24, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitboxer bitboxer bitboxer approved these changes

@lucapette lucapette lucapette approved these changes

@stayprodio stayprodio stayprodio approved these changes

@ogbeche77 ogbeche77 ogbeche77 approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small UI improvements in new Channels main page
5 participants
@AitorAlgorta @bitboxer @lucapette @stayprodio @ogbeche77