Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Golang dependencies, upgrade Gazelle #1231

Merged
merged 3 commits into from Mar 12, 2021
Merged

Fix Golang dependencies, upgrade Gazelle #1231

merged 3 commits into from Mar 12, 2021

Conversation

chrismatix
Copy link
Contributor

@chrismatix chrismatix commented Mar 12, 2021 •
edited

required for #1018

  • Importing aws sdk tools to verify dependencies are working
  • Downgrade k8s deps, because the latest version is incompatible with the golang/net package that Gazelle brings
  • Cleanup dependencies and introduce go embed directive
  • Introduce //go:embed directive to make the project go build compatible again
  • Code fixes to the update-deps tool
  • Upgrade to go 1.16

@github-actions github-actions bot added the fix label Mar 12, 2021
@chrismatix chrismatix mentioned this pull request Mar 12, 2021
Closed
@chrismatix chrismatix merged commit fe8f91f into develop Mar 12, 2021
@chrismatix chrismatix deleted the fix/1018-bazel-import branch March 12, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljupcovangelski ljupcovangelski Awaiting requested review from ljupcovangelski

@paulodiniz paulodiniz Awaiting requested review from paulodiniz

@lucapette lucapette Awaiting requested review from lucapette

@pascal-holy pascal-holy Awaiting requested review from pascal-holy

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrismatix @lucapette @pascal-holy @paulodiniz