[#1267] Created generic logo component #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucapette
suggested changes
Mar 22, 2021
| @@ -0,0 +1,56 @@ | |||
| import React, {CSSProperties, SyntheticEvent} from 'react'; | |||
| import {ReactComponent as GoogleLogo} from 'assets/images/icons/google_avatar.svg'; | |||
There was a problem hiding this comment.
I think we should rename all of them so that they resemble as close as possible the file name as discussed with you and @AitorAlgorta last week.
In this case though, I would probably renamed the files :) as the components seem to have the right name?
|
|
||
| const fallbackImageUrl = (event: SyntheticEvent<HTMLImageElement, Event>, source: string) => { | ||
| event.currentTarget.src = `https://s3.amazonaws.com/assets.airy.co/${source}_avatar.svg`; | ||
| event.currentTarget.alt = 'fallback image'; |
There was a problem hiding this comment.
Suggested change
| event.currentTarget.alt = 'fallback image'; | |
| event.currentTarget.alt = `${source} fallback image`; |
|
|
||
| return ( | ||
| <div className={styles.image} style={style}> | ||
| {channel?.metadata?.imageUrl || imageUrl ? getCustomLogo(channel) : getSourceLogo(channel)} |
There was a problem hiding this comment.
the channel can't be nil right? so channel? shouldn't be needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.