[#1615] Expose tag events via websocket #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucapette
changed the title
lucapette
force-pushed
the
feat/1615-tags-event
branch
3 times, most recently
from
d540a2e
to
82a4e08
Compare
lucapette
force-pushed
the
feat/1615-tags-event
branch
from
d70e418
to
c88947a
Compare
lucapette
force-pushed
the
feat/1615-tags-event
branch
from
8637338
to
548f8ef
Compare
AitorAlgorta
previously approved these changes
Apr 29, 2021
chrismatix
previously approved these changes
Apr 29, 2021
| delivery_state: DeliveryState; | ||
| from_contact: boolean; | ||
| sent_at: Date; | ||
| metadata: any; |
There was a problem hiding this comment.
nitpick: Message events don't include metadata.
There was a problem hiding this comment.
yeah this was already there bu I agree. I'll change!
|
|
||
| ```json5 | ||
| { | ||
| "type": "tag", |
There was a problem hiding this comment.
So for my understanding: For now we don't handle tag deletions?
There was a problem hiding this comment.
No, the reason why I didn't do this is that right now "deleting tags" is not though off so well as it doesn't cascade to conversations (and maybe we should never do that. I guess we should discuss this in a separate issue though)
| const SET_METADATA = '@@metadata/SET_METADATA'; | ||
|
|
||
| export const setMetadataAction = createAction( | ||
| SET_METADATA, | ||
| (metadataEvent: MetadataEvent) => metadataEvent | ||
| )<MetadataEvent>(); | ||
|
|
||
| export const mergeMetadataAction = createAction( |
There was a problem hiding this comment.
🎉 So this is also a step on the way to default values on the client.
AitorAlgorta
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.