[#1486] Upgrade kafka images #1691
Conversation
ljupcovangelski
force-pushed
the
chore/1486-upgrade-kafka-images
branch
2 times, most recently
from
2825d5d
to
225947c
Compare
lucapette
force-pushed
the
chore/1486-upgrade-kafka-images
branch
from
c01c2ad
to
5ace872
Compare
| try { | ||
| if (!streams.state().equals(KafkaStreams.State.RUNNING)) { |
There was a problem hiding this comment.
Prior to KAFKA-10271 the underlying QueryableStoreProvider would expensively lookup stores from all registered StreamThreadStateStoreProvider instances. StreamThreadStateStoreProvider::getStore throws an exception if the thread is not RUNNING so there was an implicit check for that whenever we requested a store.
KAFKA-10271 removed that extra lookup for performance reasons so that it became possible to access stores that would crash when trying to read from them.
There was a problem hiding this comment.
This also explains why the integration tests were failing, while the runtime was working: The state stores do eventually get ready, but for the tests that were failing they were not ready at the expected time.
required for #1486