[#1693] Move defaults to airy yaml #1700
Conversation
| return color.Colorize(color.Cyan, "#\t"+input) | ||
| }) | ||
| provider := providers.MustGet(providers.ProviderName(providerName), w) | ||
| overrides := provider.GetOverrides() |
There was a problem hiding this comment.
Instead of passing the overrides as --set flags we merge them into the airy.yaml first before using it as a values file in Helm.
There was a problem hiding this comment.
I created a cluster and AWS and the annotation for the loadbalancer was not picked-up (classical loadbalancer was created).
| } | ||
|
|
||
| //go:embed src | ||
| var templateDir embed.FS |
There was a problem hiding this comment.
Refactored the templating part of the workspace module into its own module
| if err != nil { | ||
| return err | ||
| } | ||
| if _, err := os.Stat(dstPath); err == nil { |
There was a problem hiding this comment.
This was a bug: The create command was previously overwriting config that was already present.
| @@ -6,6 +6,9 @@ go 1.16 | |||
| // Automatically generated by running //tools/update-deps | |||
|
|
|||
| require ( | |||
| github.com/Masterminds/goutils v1.1.1 // indirect | |||
| github.com/Masterminds/semver v1.5.0 // indirect | |||
| github.com/Masterminds/sprig v2.22.0+incompatible // indirect | |||
There was a problem hiding this comment.
This is the same templating library that helm uses
| data: | ||
| HOST: {{ .Values.global.host }} | ||
| HOST: {{ .Values.global.kubernetes.host }} | ||
| --- |
There was a problem hiding this comment.
Hoisted the security configmap to the top level
There was a problem hiding this comment.
I think that the order in which we generate the airy.yaml file should be:
- we grab the helm defaults
- we grab the overrides for a specific provider
- we provision
Airy corein the Kubernetes cluster add grab the generated values (such ashost) - we generate the
airy.yamlfile at the end
| return color.Colorize(color.Cyan, "#\t"+input) | ||
| }) | ||
| provider := providers.MustGet(providers.ProviderName(providerName), w) | ||
| overrides := provider.GetOverrides() |
There was a problem hiding this comment.
I created a cluster and AWS and the annotation for the loadbalancer was not picked-up (classical loadbalancer was created).
|
In an offline conversation @ljupcovangelski and I decided that the best move forward would be to:
To improve |
chrismatix
changed the title
resolves #1693