[#1752] Add connect cluster chart #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismatix
reviewed
Jun 10, 2021
pascal-holy
force-pushed
the
feature/1752-kafka-connect-deployment-for-data-export
branch
from
7e5a902
to
04533e0
Compare
chrismatix
approved these changes
Jun 16, 2021
|
|
||
| - `hostname` | ||
| - `port` | ||
|
|
||
| ### Security |
There was a problem hiding this comment.
I think now it just needs to be documented then this is ready to go. Giving an approval of appreciation 🙌
There was a problem hiding this comment.
I will add documentation to this PR #2017 since then we also have a better way to actually deploy connectors and as discussed with @ljupcovangelski we might do a separate helm chart for Kafka Connect
pascal-holy
deleted the
feature/1752-kafka-connect-deployment-for-data-export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1752