Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2744] support recording voice messages from airy inbox UI #2895

Merged
merged 32 commits into from Mar 9, 2022
Merged

[#2744] support recording voice messages from airy inbox UI #2895

merged 32 commits into from Mar 9, 2022

Conversation

AudreyKj
Copy link
Contributor

@AudreyKj AudreyKj commented Mar 3, 2022 •
edited

closes #2744
closes #2894

changes:

  • audio component revamp with waveform
  • recording audio in the UI

notes:

  • The audio recording is encoded in mp3 format before being uploaded to the backend
  • The dependency audio-recorder-polyfill ensures cross-browser support

screenshot:
Screenshot 2022-03-03 at 17 10 24

@AudreyKj AudreyKj removed the request for review from chrismatix March 3, 2022 14:56
@AudreyKj AudreyKj requested a review from stayprodio March 4, 2022 09:08
AitorAlgorta
AitorAlgorta reviewed Mar 4, 2022
View reviewed changes
Copy link
Contributor

@AitorAlgorta AitorAlgorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I left some comments

frontend/ui/src/pages/Inbox/MessageInput/InputOptions.module.scss Show resolved Hide resolved
lib/typescript/components/general/AudioClip/index.tsx Show resolved Hide resolved
lib/typescript/components/general/AudioClip/index.tsx Show resolved Hide resolved
@AudreyKj AudreyKj merged commit ae8d2aa into develop Mar 9, 2022
@AudreyKj AudreyKj deleted the feature/2744-support-recording-voice-messages-from-airy-inbox-ui branch March 9, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AitorAlgorta AitorAlgorta AitorAlgorta approved these changes

@stayprodio stayprodio Awaiting requested review from stayprodio

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AudioClip component revamp with waveform Support Recording Voice Messages from Airy Inbox UI
2 participants
@AudreyKj @AitorAlgorta