Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#413] Add /metadata.set endpoint #414

Merged
merged 10 commits into from Dec 2, 2020
Merged

[#413] Add /metadata.set endpoint #414

merged 10 commits into from Dec 2, 2020

Conversation

paulodiniz
Copy link
Contributor

@paulodiniz paulodiniz commented Nov 30, 2020 •
edited

Fixes #411

@paulodiniz paulodiniz changed the title [#413] Add /metadata.remove endpoint [#413] Add /metadata.set endpoint Dec 1, 2020
lucapette
lucapette suggested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great but we need docs 👼

lucapette
lucapette reviewed Dec 1, 2020
View reviewed changes
docs/docs/api/http.md Outdated Show resolved Hide resolved
paulodiniz
paulodiniz commented Dec 2, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
lucapette
lucapette suggested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but looking great!

...d/api/communication/src/test/java/co/airy/core/api/communication/MetadataControllerTest.java Outdated Show resolved Hide resolved
docs/docs/api/http.md Outdated Show resolved Hide resolved
docs/docs/api/http.md Outdated Show resolved Hide resolved
paulodiniz and others added 2 commits December 2, 2020 13:29
@paulodiniz @lucapette
Apply suggestions from code review
9a6062c 
Co-authored-by: lucapette <ciao@lucapette.me>
@paulodiniz
Deleting unnecessary test
2e3de90
chrismatix
chrismatix approved these changes Dec 2, 2020
View reviewed changes
...nication/src/main/java/co/airy/core/api/communication/payload/SetMetadataRequestPayload.java Outdated
@NotNull
private String conversationId;
@NotNull
@Pattern(regexp = "^((?!__.*__).)*$")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

lucapette
lucapette approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@paulodiniz paulodiniz merged commit 1b5e137 into develop Dec 2, 2020
@paulodiniz paulodiniz deleted the feature/411-add-metadata-set-endpoint branch December 2, 2020 14:06
@paulodiniz paulodiniz added this to In progress in Engineering WIP via automation Dec 2, 2020
@paulodiniz paulodiniz moved this from In progress to Done in Engineering WIP Dec 2, 2020
@paulodiniz paulodiniz removed this from Done in Engineering WIP Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucapette lucapette lucapette approved these changes

@chrismatix chrismatix chrismatix approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add /metadata.set Endpoint
3 participants
@paulodiniz @lucapette @chrismatix