Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unread count #42

Merged
merged 4 commits into from Oct 8, 2020
Merged

Unread count #42

merged 4 commits into from Oct 8, 2020

Conversation

chrismatix
Copy link
Contributor

addresses #39

chrismatix
chrismatix commented Oct 7, 2020
View reviewed changes
backend/api/conversations/src/main/java/co/airy/core/api/conversations/Stores.java

unreadCountTable.toStream()
.peek((conversationId, unreadCountState) -> {
// TODO send to websocket queue
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending the websocket PR

paulodiniz
paulodiniz previously approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@paulodiniz paulodiniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 NICE

lucapette
lucapette reviewed Oct 7, 2020
View reviewed changes
...end/api/conversations/src/main/java/co/airy/core/api/conversations/dto/UnreadCountState.java Outdated
@NoArgsConstructor
@AllArgsConstructor
public class UnreadCountState implements Serializable {
HashSet<Long> messageSentDates = new HashSet<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set<Long> for the declaration

lucapette
lucapette reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good stuff!

@chrismatix chrismatix marked this pull request as ready for review October 8, 2020 07:23
lucapette
lucapette reviewed Oct 8, 2020
View reviewed changes
backend/avro/communication/read-receipt.avsc Outdated
"type": "record",
"fields": [
{"name": "conversationId", "type": "string"},
{"name": "lastReadDate", "type": "long", "logicalType": "timestamp-millis"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd call this field readAt(so that it stays in sync with common industry conventions, like sentAt and such)

lucapette
lucapette reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass! Looking good.... I'm unsure about the current naming (I suggested something) but apart from that I think it's good to go

lucapette
lucapette approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chrismatix chrismatix merged commit 5adcc99 into main Oct 8, 2020
@chrismatix chrismatix deleted the unread-count branch October 8, 2020 08:12
@paulodiniz paulodiniz mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucapette lucapette lucapette approved these changes

@paulodiniz paulodiniz paulodiniz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrismatix @lucapette @paulodiniz