Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/598 read unread state of conversations #617

Merged
merged 12 commits into from Jan 14, 2021
Merged

Feature/598 read unread state of conversations #617

merged 12 commits into from Jan 14, 2021

Conversation

AudreyKj
Copy link
Contributor

@AudreyKj AudreyKj commented Jan 12, 2021 •
edited

resolves #598

changes:

  • readConversations endpoint in http lib
  • readConversations action + reducer
  • added check to api config because the readConversations endpoint returns a 202 with an empty response

@AudreyKj AudreyKj marked this pull request as ready for review January 13, 2021 08:10
lucapette
lucapette previously approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. :shipit:

lib/typescript/httpclient/api/airyConfig.ts Outdated Show resolved Hide resolved
bitboxer
bitboxer previously approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@bitboxer bitboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nitpick, looking good.

lib/typescript/httpclient/api/airyConfig.ts Outdated Show resolved Hide resolved
@AudreyKj AudreyKj dismissed stale reviews from bitboxer and lucapette via 0650269 January 13, 2021 10:16
chrismatix
chrismatix reviewed Jan 13, 2021
View reviewed changes
Copy link
Contributor

@chrismatix chrismatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass

lib/typescript/httpclient/api/airyConfig.ts Outdated Show resolved Hide resolved
lib/typescript/httpclient/endpoints/readConversations.ts Outdated Show resolved Hide resolved
bitboxer
bitboxer approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@bitboxer bitboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bitboxer
Copy link
Contributor

Sadly there is a merge conflict 😢 . Sorry that you need to change something again.

@AudreyKj AudreyKj merged commit f345889 into develop Jan 14, 2021
@AudreyKj AudreyKj deleted the feature/598-read-unread-state-of-conversations branch January 14, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismatix chrismatix chrismatix left review comments

@bitboxer bitboxer bitboxer approved these changes

@AitorAlgorta AitorAlgorta AitorAlgorta approved these changes

@lucapette lucapette lucapette left review comments

@ogbeche77 ogbeche77 Awaiting requested review from ogbeche77

@stayprodio stayprodio Awaiting requested review from stayprodio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read/Unread state of conversations
5 participants
@AudreyKj @bitboxer @lucapette @chrismatix @AitorAlgorta