Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images #86

Merged
merged 6 commits into from Oct 15, 2020
Merged

Images #86

merged 6 commits into from Oct 15, 2020

Conversation

ljupcovangelski
Copy link
Contributor

  • Rearranged the infrastructure folder a bit: removed bootstrap and packer folders, put the yamls inside separate directories.
  • When you want to start the system ./bootstrap.sh or vagrant up
  • When you want to do something custom vagrant up airy-core-custom
  • When you want to create a new image packer build image.vagrant.json

lucapette
lucapette reviewed Oct 14, 2020
View reviewed changes
README.md Show resolved Hide resolved
lucapette
lucapette previously requested changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're complicating installation but there's no reason to do so

pascal-holy
pascal-holy previously approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@pascal-holy pascal-holy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

pascal-holy
pascal-holy previously approved these changes Oct 15, 2020
View reviewed changes
@ljupcovangelski ljupcovangelski dismissed lucapette’s stale review October 15, 2020 13:08

We are merging like this for now, we'll fix it after.

@ljupcovangelski ljupcovangelski merged commit 1d3d5b3 into main Oct 15, 2020
@ljupcovangelski ljupcovangelski deleted the images branch October 15, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-holy pascal-holy pascal-holy approved these changes

@lucapette lucapette lucapette left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ljupcovangelski @lucapette @pascal-holy