added run to CLI #35
Merged
added run to CLI #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeping-ng
reviewed
Apr 21, 2021
| @@ -22,12 +22,12 @@ This toolkit provides state of the art computer vision models to make real time | |||
|
|
|||
| ## How to Use for Developers (Temporary) | |||
|
|
|||
| - git clone this repo | |||
| - `git clone` this repo | |||
leeping-ng
reviewed
Apr 21, 2021
leeping-ng
reviewed
Apr 21, 2021
peekingduck/cli.py
Outdated
| @@ -55,7 +79,7 @@ def get_configs(config_path): | |||
| with open('node_config.yml', 'a') as node_configs: | |||
| for node in nodes: | |||
| module, node_name = node.split('.') | |||
| if node_path[0] == 'custom': | |||
| if module == 'custom': | |||
There was a problem hiding this comment.
shall we replace module with node_type? To be consistent with CONTRIBUTING.md
leeping-ng
reviewed
Apr 21, 2021
This was referenced Apr 21, 2021
|
Can we remove "test" from the package-name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.