Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added standarized logging formatt #39

Merged
merged 6 commits into from
Apr 23, 2021
Merged

Added standarized logging formatt #39

merged 6 commits into from
Apr 23, 2021

Conversation

chngzyk
Copy link
Contributor

@chngzyk chngzyk commented Apr 21, 2021

No description provided.

@chngzyk chngzyk requested a review from sidney-tio April 21, 2021 08:39
@chngzyk chngzyk self-assigned this Apr 21, 2021
@sidney-tio
Copy link
Contributor

suggest to add self.logger to AbstractNode so that new nodes need not handle logging. the other classes (e.g. runner) will have to do this as well

@sidney-tio
Copy link
Contributor

__main__.py will be deprecated soon; to add setupLogger to cli.py once #35 has been merged

@sidney-tio sidney-tio mentioned this pull request Apr 21, 2021
Closed
sidney-tio
sidney-tio suggested changes Apr 21, 2021
View reviewed changes
peekingduck/pipeline/nodes/input/recorded.py Outdated Show resolved Hide resolved
peekingduck/pipeline/nodes/input/recorded.py Outdated Show resolved Hide resolved
peekingduck/pipeline/nodes/model/yolo/yolo_files/detector.py Outdated Show resolved Hide resolved
peekingduck/pipeline/nodes/model/yolo/yolo_files/detector.py Outdated Show resolved Hide resolved
peekingduck/pipeline/nodes/model/yolo/yolo_model.py Outdated Show resolved Hide resolved
peekingduck/pipeline/nodes/model/yolo/yolo_model.py Outdated Show resolved Hide resolved
peekingduck/pipeline/nodes/usecase/peoplecounting.py Outdated Show resolved Hide resolved
peekingduck/pipeline/nodes/usecase/peoplecounting.py Outdated Show resolved Hide resolved
@sidney-tio sidney-tio merged commit 5b09bb2 into dev Apr 23, 2021
@sidney-tio sidney-tio deleted the dev-addLogger branch May 18, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidney-tio sidney-tio sidney-tio approved these changes

Assignees

@chngzyk chngzyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chngzyk @sidney-tio