-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect python code crash problem - fixed in cutting edge release #606
Comments
Hi Murat, I'm afraid not. The assumption is valid Python code is sent to the Python integration. If you really want to explore this, you can try modifying |
Thank you Ken |
Ok Murat, I will also see if there is something that can be changed in below file which can be committed to the codebase without affecting backward compatibility - |
Going to make a commit that works with Python 2 and 3, and also the following test - script
result
|
see aisingapore#606 for more details. with this commit, when invalid Python code is called by user, TagUI continues operation and the error message is stored in py_result. before this change, TagUI hangs as the Python process does not return response.
see #606 for more details. with this commit, when invalid Python code is called by user, TagUI continues operation and the error message is stored in py_result. before this change, TagUI hangs as the Python process does not return response.
This is now available in the cutting edge release. With above commit, when invalid Python code is called by user, TagUI continues operation and the error message is stored in py_result. Before this change, TagUI hangs as the Python process does not return response. Works for Python 2 & 3 and the test case above. Thanks Murat for raising this feedback! Running your example on a = 4/0 and echo py_result will now show 'integer division or modulo by zero' message, instead of hanging there. https://github.com/kelaberetiv/TagUI#set-up To try cutting edge version with the latest features, download master.zip to overwrite your existing packaged installation (be sure to manually select and move the folders & files inside master.zip's TagUI-master/src folder to replace your existing tagui/src folder, some OSes will delete existing target folders that are missing from source folder) |
see aisingapore#606 for details. adding this to be consistent with TagUI error messages, and also have something meaningful for user to know if the execution of Python code runs into error.
Adding a further commit so that when error happens running the Python code from user, there is an 'ERROR - ' in front of the error message. Without this, py_result is ambiguous. This is both for consistency in TagUI error messages and also for user to be able to validate without ambiguity whether the response returned is due to error running the code. Thus running Available in cutting edge version - https://github.com/kelaberetiv/TagUI#set-up To try cutting edge version with the latest features, download master.zip to overwrite your existing packaged installation (be sure to manually select and move the folders & files inside master.zip's TagUI-master/src folder to replace your existing tagui/src folder, some OSes will delete existing target folders that are missing from source folder) |
Hi Ken
Application be locked when there is an error in a Python block.
Is there a method of terminating when an error is thrown with a python block?
I'm applying a method like this for
The text was updated successfully, but these errors were encountered: