Skip to content

Commit

Permalink
feat: update signatures after controller-runtime update
Browse files Browse the repository at this point in the history
- Removal of deprecated manager options:
  - kubernetes-sigs/controller-runtime#2422
- Context added to `EnqueueRequestsFromMapFunc`
  - kubernetes-sigs/controller-runtime#2139
  • Loading branch information
rriski committed Jan 24, 2024
1 parent 8f09ce8 commit 3edd57b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 13 deletions.
7 changes: 3 additions & 4 deletions controllers/secret_finalizer_gc_controller.go
Expand Up @@ -20,7 +20,6 @@ import (
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/predicate"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"

"github.com/aiven/aiven-operator/api/v1alpha1"
)
Expand Down Expand Up @@ -52,10 +51,10 @@ func (c *SecretFinalizerGCController) SetupWithManager(mgr ctrl.Manager, hasDefa
})

// watch aiven CRDs to queue secret reconciliations
for i := range aivenManagedTypes {
for _, aivenManagedType := range aivenManagedTypes {
builder.Watches(
&source.Kind{Type: aivenManagedTypes[i]},
handler.EnqueueRequestsFromMapFunc(func(a client.Object) []reconcile.Request {
aivenManagedType,
handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, a client.Object) []reconcile.Request {
ao := a.(v1alpha1.AivenManagedObject)
if auth := ao.AuthSecretRef(); auth != nil {
return []reconcile.Request{
Expand Down
6 changes: 2 additions & 4 deletions main.go
Expand Up @@ -14,6 +14,7 @@ import (
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/healthz"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"

"github.com/aiven/aiven-operator/api/v1alpha1"
"github.com/aiven/aiven-operator/controllers"
Expand All @@ -28,8 +29,6 @@ var (
setupLog = ctrl.Log.WithName("setup")
)

const port = 9443

func init() {
utilruntime.Must(clientgoscheme.AddToScheme(scheme))
utilruntime.Must(v1alpha1.AddToScheme(scheme))
Expand Down Expand Up @@ -57,8 +56,7 @@ func main() {

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
Scheme: scheme,
MetricsBindAddress: metricsAddr,
Port: port,
Metrics: metricsserver.Options{BindAddress: metricsAddr},
HealthProbeBindAddress: probeAddr,
LeaderElection: enableLeaderElection,
LeaderElectionID: "40db2fac.aiven.io",
Expand Down
11 changes: 6 additions & 5 deletions tests/suite_test.go
Expand Up @@ -110,12 +110,13 @@ func setupSuite() error {
}

mgr, err := ctrl.NewManager(cfg, ctrl.Options{
Scheme: scheme.Scheme,
MetricsBindAddress: "0",
CertDir: testEnv.WebhookInstallOptions.LocalServingCertDir,
Port: testEnv.WebhookInstallOptions.LocalServingPort,
Scheme: scheme.Scheme,
Metrics: metricsserver.Options{BindAddress: "0"},
WebhookServer: webhook.NewServer(webhook.Options{
Port: testEnv.WebhookInstallOptions.LocalServingPort,
CertDir: testEnv.WebhookInstallOptions.LocalServingCertDir,
}),
})

if err != nil {
return err
}
Expand Down

0 comments on commit 3edd57b

Please sign in to comment.