Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errors in status conditions #600

Closed
mortenlj opened this issue Jan 23, 2024 · 3 comments
Closed

Show errors in status conditions #600

mortenlj opened this issue Jan 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@mortenlj
Copy link
Contributor

If the operator encounters an error when calling the Aiven API (for instance if there are invalid values in the resource being updated), those errors are logged, but nothing is reflected on the actual resource.

Since the resource is the interface for the developer, it would be expected that any errors are shown there in some way.
It could for instance be by updating the Conditions fields with proper details for the current status and last known state/message.

@byashimov byashimov added the enhancement New feature or request label Jan 26, 2024
@christoffer-eide
Copy link
Contributor

+1 for this feature. A common issue for us, is that devs reduces the partition count on a topic.
When the operator tries to reconcile, the request is rejected by the aiven api.
This error is only shown as an event on the KafkaTopic, and is easy to miss:

unable to create or update aiven instance: cannot update Kafka Topic: 400: 
{"errors":[{"error_code":"kafka_topic_invalid_config","message":"Reducing partition count is not supported","status":400}],"message":"Reducing partition count is not supported"}

@mortenlj
Copy link
Contributor Author

@mortenlj
Copy link
Contributor Author

It looks like this was solved in v0.16.0, so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants